Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Router #72

Merged
merged 22 commits into from
Apr 16, 2024
Merged

Router #72

merged 22 commits into from
Apr 16, 2024

Conversation

joshparent
Copy link
Contributor

  • Updates URL path based on what building/floor/room the user selected
  • Manual URL path input
    • Map automatically goes to the requested building/floor/room

@joshparent joshparent requested a review from paulbruzzi April 16, 2024 20:29
@paulbruzzi
Copy link
Contributor

There are a couple of problems with the current state of this branch. Routing should route to the ground floor if the user types in https://vacansee.github.io/app/DCC/, but right now it just route to the home page. Also if you manually change a URL it should also change the page, not just route to the homepage (it works for some buildings but not others). If I user puts in an incorrect floor (for example app/DCC/12) it should also route to the ground floor.

@paulbruzzi paulbruzzi marked this pull request as ready for review April 16, 2024 21:33
@Acumane Acumane self-requested a review April 16, 2024 22:03
Acumane
Acumane approved these changes Apr 16, 2024
View reviewed changes
Copy link
Member

@Acumane Acumane left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missing browser back/forward support, but the rest is robust.
Merging, good work

@Acumane Acumane merged commit a5d488f into dev Apr 16, 2024
1 of 2 checks passed
@Acumane Acumane deleted the router branch April 16, 2024 22:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Acumane Acumane Acumane approved these changes

@paulbruzzi paulbruzzi Awaiting requested review from paulbruzzi

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@joshparent @paulbruzzi @Acumane